Skip to content

Show correct text when comparing commits on empty pull request #16569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 29, 2021
Merged

Show correct text when comparing commits on empty pull request #16569

merged 4 commits into from
Jul 29, 2021

Conversation

PotatoesFall
Copy link
Contributor

Targeting issue: #16568

@PotatoesFall PotatoesFall mentioned this pull request Jul 28, 2021
Closed
2 tasks
zeripath
zeripath reviewed Jul 28, 2021
View reviewed changes
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 28, 2021
@zeripath zeripath added the topic/ui Change the appearance of the Gitea UI label Jul 28, 2021
@zeripath zeripath added this to the 1.16.0 milestone Jul 28, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 28, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #16569 (a05ebec) into main (3705168) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16569      +/-   ##
==========================================
- Coverage   45.37%   45.37%   -0.01%     
==========================================
  Files         750      750              
  Lines       85084    85086       +2     
==========================================
- Hits        38606    38605       -1     
- Misses      40235    40236       +1     
- Partials     6243     6245       +2
Impacted Files Coverage Δ
routers/web/repo/pull.go 30.32% <0.00%> (-0.07%) ⬇️
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/git/blame.go 65.71% <0.00%> (-1.43%) ⬇️
services/pull/pull.go 41.73% <0.00%> (ø)
modules/queue/workerpool.go 54.96% <0.00%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3705168...a05ebec. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 29, 2021
@zeripath
Copy link
Contributor

Make lgtm work

@zeripath zeripath merged commit 4e68d6f into go-gitea:main Jul 29, 2021
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@PotatoesFall @zeripath @AbdulrhmnGhanem
Show correct text when comparing commits on empty pull request (go-gi…
2a58298 
…tea#16569)

* fix

* use own text

* Update templates/repo/commits_table.tmpl

Co-authored-by: marty <[email protected]>
Co-authored-by: zeripath <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@PotatoesFall @codecov-commenter @zeripath @lunny @GiteaBot